Wait for migrating activations to become active or terminated #8527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some test flakiness caused by a race in the grain migration process. This PR fixes that race by polling the grains to make sure that they enter an active or terminal state before returning from migration.
The second commit also fixes a test case issue. The issue is that telling a grain to migrate by calling
MigrateOnIdledoes not guarantee that subsequent messages will be enqueued instead of executed on the activation (i.e, migration is async). The fix is to check that we're dealing with a new activation before continuing with the test.Microsoft Reviewers: Open in CodeFlow