Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added HostApplicationBuilder extensions #8466

Merged
merged 3 commits into from
Jun 5, 2023
Merged

Added HostApplicationBuilder extensions #8466

merged 3 commits into from
Jun 5, 2023

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Jun 5, 2023 •
edited
Loading

In this PR (related to #8465):

  • The Orleans.Core.csproj now depends on Microsoft.Extensions.Hosting, instead of just the Microsoft.Extensions.Hosting.Abstractions.
  • Exposed an UseOrleans/UseOrleansClient extension on the HostApplicationBuilder API.
  • Update the unit tests to use the new extension, see test/DefaultCluster.Tests/HostedClientTests.cs.
  • Use ArgumentNullException.ThrowIfNull in updated src/Orleans.Runtime/Hosting/GenericHostExtensions.cs.
Microsoft Reviewers: Open in CodeFlow

@IEvangelist IEvangelist requested a review from ReubenBond June 5, 2023 20:47
ReubenBond
ReubenBond approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@ReubenBond ReubenBond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I removed an unnecessary check (it happens again immediately after already)

@ReubenBond ReubenBond merged commit e8dc1e7 into dotnet:main Jun 5, 2023
@IEvangelist IEvangelist deleted the hostapplication branch June 6, 2023 14:20
@IEvangelist IEvangelist mentioned this pull request Jun 6, 2023
Merged
@IEvangelist
Copy link
Member Author

Consider updating these changes once dotnet/runtime#85486 is merged, such that we could instead use the IHostApplicationBuilder instead.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ReubenBond ReubenBond ReubenBond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IEvangelist @ReubenBond