Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestHost - Client ability to use IHostConfigurator to align w/ Silo functionality #8454

Merged

Conversation

cmeyertons
Copy link
Contributor

@cmeyertons cmeyertons commented May 26, 2023

This PR aims to align client / silo host building capabilities while building a TestCluster

Use Case

In some use cases, a test application is attempting to set up a common configuration source between client / silo but is dependent on the HostBuilderContext in order to do so. An example would be trying to mirror default .NET behavior for app settings files, env variables, etc.

The silo configurator mechanism has hooks to hook directly into the IHostBuilder instance itself and do more robust customizations.

By aligning the client side logic w/ the silo logic, end users can have common, shared code for configuring their TestCluster

Microsoft Reviewers: Open in CodeFlow

@ReubenBond
Copy link
Member

Thank you! I have also found the need for this and have implemented it in one of my (otherwise unrelated branches). LGTM

@ReubenBond ReubenBond self-assigned this Jun 1, 2023
@ReubenBond
Copy link
Member

Rebased & will merge soon.

@ReubenBond ReubenBond merged commit e176077 into dotnet:main Jun 6, 2023
@cmeyertons cmeyertons deleted the feature/test-host-client-host-configurator branch June 12, 2023 20:43
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants