Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf copiers/codecs for data types #8359

Merged
merged 5 commits into from
Apr 11, 2023

Conversation

jsteinich
Copy link
Contributor

@jsteinich jsteinich commented Mar 31, 2023

There are a few protobuf types that don't extend from IMessage so they won't be covered by the general protobuf copier.
One place this can come up is from the transaction system.

Microsoft Reviewers: Open in CodeFlow

@ReubenBond ReubenBond self-assigned this Mar 31, 2023
@ReubenBond
Copy link
Member

Thanks, @jsteinich! Am I understanding correctly that these types can currently be serialized via the existing Protocol Buffers integration but not copied, or do we never need to serialize them?

@jsteinich
Copy link
Contributor Author

Thanks, @jsteinich! Am I understanding correctly that these types can currently be serialized via the existing Protocol Buffers integration but not copied, or do we never need to serialize them?

They can be serialized by the existing integration when they are contained within an IMessage. If they were used directly in a grain method than they would fail to serialize.
We should also add codecs to cover that case. I should be able to do that next week.

@jsteinich jsteinich changed the title Protobuf copiers Protobuf copiers/codecs for data types Apr 3, 2023
@ReubenBond ReubenBond merged commit 9e85ac7 into dotnet:main Apr 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants