Adds support to Orleans.Analyzers for generic attributes #8352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that would cause intermittent failure of the test
|
@dotnet-policy-service agree |
|
@ReubenBond -- I have fixed an error here in the analyzers (detailed in the description) and I believe I have also fixed an intermittent error in a unit test due to a race condition that was blocking the build of my original fix in the analyzers. |
|
Thank you, @michaelmccord! |
ReubenBond
approved these changes
Mar 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to Orleans.Analyzers for generic attributes a new feature in C# 11.0.
Currently, if you use a generic attribute in your code, the the orleans analyzers will fail during the analysis phase and throw a "NotSupportedException" when encountering a usage of a generic attribute. This causes a AD0001 analysis error to appear.
A temporary work around for this is to simply use
<NoWarn>AD0001</NoWarn>on the project. However, this can potentially hide other base level analyzer exception errors and is therefore not a long-term work around.Microsoft Reviewers: Open in CodeFlow