Fix type parsing of type names with generic array parameter #8337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8330
This is a generics corner case which was stumping the type parser when parsing a formatted unconstructed generic type.
For example, this type would not round-trip successfully:
typeof(List<>).MakeGenericType(typeof(Inner<>.Middle).MakeArrayType())
Concretely, this behavior was being hit when compiling the grain manifest for a type like
IGenericArrayRegisterGrain<T>
, since the manifest would contain the implemented interfaces, which containsIGenericRegisterGrain<T[]>
(with no concreteT
):The fix is to check that we are indeed looking at a formatted generic type, versus an array, by reading ahead for the presence of
[[
(indicating a generic parameter list) rather than just[
(ambiguous between an array specification or generic parameter list)Microsoft Reviewers: Open in CodeFlow