Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mariadb tests #8198

Merged
merged 4 commits into from
Nov 30, 2022
Merged

Fix mariadb tests #8198

merged 4 commits into from
Nov 30, 2022

Conversation

benjaminpetit
Copy link
Member

@benjaminpetit benjaminpetit commented Nov 29, 2022 •
edited by ghost
Loading

  • Some tests were skipped if the setup failed. Tests should fail, not skip in this case.
  • Failures started when 10.10 was released. I think we should target our tests against the latest LTS version (currently 10.6)
Microsoft Reviewers: Open in CodeFlow

@ReubenBond ReubenBond merged commit 9f873f5 into dotnet:main Nov 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ReubenBond ReubenBond ReubenBond approved these changes

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjaminpetit @ReubenBond