Use code generated or compiled regular expressions where possible #8141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces all regular expression usages in the project with source generated or at least dynamically compiled ones. It should increase performance a bit, especially in code generator which is now using source generators, isn't it? Also projects using Orleans will have more room for their regexps' cache because global Regex cache's size is quite small (15) and Orleans will not use it now.
As it is my first contribution to Orleans, I still have questions:
I'm planning to do more meaningful contributions (such as analyzers) so any feedback is appreciated. Thanks.
Microsoft Reviewers: Open in CodeFlow