Upgrade 'Bank Account' sample #8119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
reviewed
Nov 10, 2022
ReubenBond
approved these changes
Nov 10, 2022
17 tasks
gfoidl
reviewed
Nov 10, 2022
| .Build(); | ||
|
|
||
| await client.Connect(); | ||
| await host.StartAsync(); |
There was a problem hiding this comment.
Should the host be stopped (explicitely) after the loop too?
More or less for completeness and to show good behavior.
There was a problem hiding this comment.
Yes, you're right, it should
There was a problem hiding this comment.
Actually, we should change this to use the host lifecycle (which should be the console lifecycle). I'll push an update.
ReubenBond
approved these changes
Nov 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #8035
Microsoft Reviewers: Open in CodeFlow