Add timeout mecanism for grain deactivation #4883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
reviewed
Aug 23, 2018
| @@ -25,6 +26,10 @@ public Task Task | |||
| get { return tcs.Task; } | |||
| } | |||
|
|
|||
| public bool TrySetCancelled(CancellationToken ct) | |||
There was a problem hiding this comment.
Spelling of Cancelled is inconsistent with TPL
There was a problem hiding this comment.
(and afaict, this method is never called)
This was referenced Aug 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not the fix I intended to write, but I thinks used in conjunction with #4875, it should fix the issues encountered in #4774 and #4757