Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NullReferenceException in ExecutingWorkItemsTracker #4850

Merged
merged 1 commit into from
Aug 16, 2018
Merged

Fix NullReferenceException in ExecutingWorkItemsTracker #4850

merged 1 commit into from
Aug 16, 2018

Conversation

ReubenBond
Copy link
Member

@ReubenBond ReubenBond commented Aug 15, 2018 •
edited
Loading

I hit a NullReferenceException here while debugging #4617.

The root cause was the order of initialization of log and executingWorkTracker in the ThreadPoolExecutor constructor.

This PR fixes that, adds some defensiveness, and cleans up the code a little.

@sergeybykov sergeybykov added this to the 2.1.0 milestone Aug 15, 2018
@benjaminpetit benjaminpetit merged commit d1b87c7 into dotnet:master Aug 16, 2018
@ReubenBond ReubenBond deleted the fix-nre-ExecutingWorkItemsTracker branch August 16, 2018 21:22
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benjaminpetit benjaminpetit benjaminpetit approved these changes

Assignees

@benjaminpetit benjaminpetit

Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ReubenBond @benjaminpetit @sergeybykov