Cleanup pass on Transaction abstractions and public surface. #4628
Conversation
jason-bragg
commented
May 25, 2018
jason-bragg
commented
- Removed leftover code from singleton TM.
- Moves agent abtraction from core to runtime abstractions
- Cleaned up agent initialization and usage pattern
- Reduced public surface of transactional state abstraction
- Moved transaction info out of abstractions
- Removed old unsused logging errorcodes.
- Moved serialization generation assembly statements to files that defined the serializable classes.
| /// </summary> | ||
| internal enum OrleansTransactionsErrorCode | ||
| { | ||
| /// <summary> | ||
| /// Start of orlean servicebus errocodes | ||
| /// Start of orlean transactions errocodes |
| { | ||
| logger.Error((int)errorCode, message, exception); | ||
| } | ||
| // TODO - jbragg - add error codes for transaction errors - User Story 62 |
There was a problem hiding this comment.
IMO we should add a link to the story in VSO - it's easy to forget where User Story 62 lives
There was a problem hiding this comment.
Tasking is a mess right now, will remove reference to specific task as odds of link or task remaining the same by the time we get to fixing this is fairly weak.
| using Orleans.Concurrency; | ||
|
|
||
| [assembly: GenerateSerializer(typeof(Orleans.Transactions.Abstractions.PendingTransactionState<>))] | ||
| [assembly: GenerateSerializer(typeof(Orleans.Transactions.Abstractions.TransactionalStorageLoadResponse<>))] |
There was a problem hiding this comment.
I prefer assembly-level attributes live in a file called AssemblyInfo.cs which only contains assembly-level metadata
There was a problem hiding this comment.
Can you provide your reasoning?
I've moved to this pattern due to maintainability. Having this declared in the same file as the type makes the serialization expectation more explicit to the maintainers. Until we resolve our backwards compatibility issues, this sort of awareness is very important.
- Removed leftover code from singleton TM. - Moves agent abtraction from core to runtime abstractions - Cleaned up agent initialization and usage pattern - Reduced public surface of transactional state abstraction - Moved transaction info out of abstractions - Removed old unsused logging errorcodes. - Moved serialization generation assembly statements to files that defined the serializable classes.
- Cleand up comments and typos
jason-bragg
force-pushed
the
TransactionsCleanup
branch
from
cf4163f to
0dbff8f
Compare
