Fix Transactional StorageProvider Wrapper #4599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndexOutOfRangeException
jason-bragg
approved these changes
May 16, 2018
|
|
||
|
|
||
| // control the tracing of the various components of the transaction mechanism | ||
| public static ISiloHostBuilder ConfigureTracingForTransactionTests(this ISiloHostBuilder hostBuilder) |
There was a problem hiding this comment.
Suggest putting this in it's own extensions class. It's not a 'test constant'
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in TransactionalStateStorageProviderWrapper. This was a very plain bug causing an IndexOutOfRangeException; interestingly, it made it past the original unit tests.
This bug was caught yesterday by the concurrency tests (#4595). That's exactly why we need those.
In this same PR I am also making a small change to reorganize the tracing configuration for transaction test cases to make it easier to control.