Transactions simplified to use distributed transaction manager only. #4568
Conversation
|
This seems like a rather large change and is a bit hard to follow through diffs. Admittedly I haven't dug into the Distributed TM in much detail, but perhaps a short summary of it would help. Looking through, the changes to I also see #4566 and it is a bit unclear (without spending more time reading it) what exactly is getting stored. Is is just information about the transactions or is it actually the "grain" state? If it is actually the grain state that is possibly a blocker for our use. If it is just transaction information we'll need a DynamoDB implementation. I'm happy to help with that once I get a chance to read through everything more. |
There was a problem hiding this comment.
Seems all very straightforward; some changes overlap with #4566. I haven't yet looked into test results but it is probably better to do that after we merge.
| services.TryAddSingleton<Factory<ITransactionAgent>>(sp => () => sp.GetRequiredService<ITransactionAgent>()); | ||
| services.TryAddSingleton<ITransactionManagerService, DisabledTransactionManagerService>(); | ||
| //services.TryAddSingleton<ITransactionAgent, DisabledTransactionAgent>(); |
There was a problem hiding this comment.
is this comment still needed? Seems that the DisabledTransactionAgent is gone.
| Task<CommitTransactionsResponse> CommitTransactions(List<TransactionInfo> transactions, HashSet<long> queries); | ||
| Task AbortTransaction(long transactionId, OrleansTransactionAbortedException reason); | ||
| } | ||
|
|
||
| [Serializable] | ||
| public struct CommitResult |
There was a problem hiding this comment.
Are the structs in this file still used somewhere? I can't find any occurrences.
jason-bragg
force-pushed
the
KillSingletonTransactionManager
branch
from
e3218e6 to
e4c16ed
Compare
jason-bragg
changed the title
|
@dotnet-bot test this please |
|
@jsteinich At a high level, the distributed TM pattern picks a grain involved in the transaction to act as the TM for that transaction, We don't have any design documentation for this (as far as I know) as it was developed in research. The distributed TM logic was check in previously in "draft of distributed TM implementation #3820". May be easyer to look at that PR when familiarizing yourself. This PR mostly just pulls out the singleton TM and make the distributed tech the only one we support. |
|
I see 369 bvt failing, while majority of them isn't tx related. WHat's going on? are they pass locally? |
|
No, It's a bug. Fixing. Transaction agent is only added in transaction tests, but requested by all. Adding default agent. |
jason-bragg
force-pushed
the
KillSingletonTransactionManager
branch
from
67b5ba8 to
ef62122
Compare
|
@dotnet-bot test functional please |
Removed singleton transaction manager and abstractions related to that pattern.
Still work in progress, as it should be rebased on Sebastian's transaction storage work, once that goes in.
Removed dynamoDb transaction work because there was nothing left once log storage was removed. Related assemblies and tests are still under source control and can be brought back if/when transactional storage impl is introduced.