New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally include @(Compile) cache file #4258

Merged

sergeybykov merged 1 commit into dotnet:master from ReubenBond:fix-codegen-cache

Mar 21, 2018

Member

ReubenBond commented Mar 21, 2018 •

edited

Loading

Fixes #4189 again

Un-reverts #4256

The differences between this and #4224 are:

Only includes the .CoreCompileInputs.cache file if it exists (which was a problem during Pack)
Fixes the codegen target between ResolveReferences & AssignTargetPaths instead of ResolveReferences & CoreCompile

I'll add a comment when load tests have finished, since they consume the NuGet packages and are what tipped us off last time.


          Conditionally include @(Compile) cache file

sergeybykov merged commit f86648a into dotnet:master

ReubenBond deleted the fix-codegen-cache branch

March 21, 2018 19:40

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet