Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orleans.TestingHost: support for .NET Standard #4223

Merged
merged 5 commits into from
Mar 22, 2018
Merged

Orleans.TestingHost: support for .NET Standard #4223

merged 5 commits into from
Mar 22, 2018

Conversation

ReubenBond
Copy link
Member

No description provided.

@ReubenBond ReubenBond force-pushed the feature-testhost-netcore branch from dda3f5b to 1b68b05 Compare March 14, 2018 23:42
@sergeybykov
Copy link
Contributor

Does it make sense to move Orleans.TestingHost.AppDomain to test\Orleans.TestingHost.AppDomain?

@sergeybykov sergeybykov added this to the 2.0.0 milestone Mar 15, 2018
@sergeybykov
Copy link
Contributor

I see a bunch of

System.IO.FileNotFoundException : Could not load file or assembly 'Orleans.TestingHost.AppDomain, Version=2.0.0.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies. The system cannot find the file specified.

error in functionals in VSTS.

@ReubenBond ReubenBond force-pushed the feature-testhost-netcore branch from 1b68b05 to 6077d52 Compare March 16, 2018 06:33
@ReubenBond
Copy link
Member Author

Tests failing because of shared static CounterStatistic

@ReubenBond
Copy link
Member Author

FYI: this PR is waiting on #4235

@ReubenBond ReubenBond force-pushed the feature-testhost-netcore branch from fafa32e to 0a9520b Compare March 21, 2018 05:18
@ReubenBond ReubenBond changed the title [WIP] Orleans.TestingHost: support for .NET Standard Orleans.TestingHost: support for .NET Standard Mar 21, 2018
@galvesribeiro
Copy link
Member

@dotnet-bot test functional

@sergeybykov
Copy link
Contributor

There are some functional test failures - https://orleans.visualstudio.com/Orleans/_build/index?buildId=9399&_a=summary&tab=ms.vss-test-web.test-result-details.

@ReubenBond ReubenBond force-pushed the feature-testhost-netcore branch from e030a1d to b82a805 Compare March 21, 2018 20:18
@ReubenBond
Copy link
Member Author

It might be that some failing tests aren't fully isolated, but I want to run with this rebased version before investigating more deeply.

@ReubenBond ReubenBond force-pushed the feature-testhost-netcore branch from b82a805 to 03f0fc6 Compare March 22, 2018 00:09
@ReubenBond
Copy link
Member Author

ReubenBond commented Mar 22, 2018 •
edited
Loading

This is passing here and in VSO. The last commit is not needed, so I'll remove it. It's benign (EDIT: removed)

@ReubenBond ReubenBond force-pushed the feature-testhost-netcore branch from 3c79c9b to bdc8d5c Compare March 22, 2018 10:23
@sergeybykov sergeybykov merged commit 92b7368 into dotnet:master Mar 22, 2018
@galvesribeiro
Copy link
Member

:shipit:

@sergeybykov sergeybykov mentioned this pull request Mar 23, 2018
Closed
@ReubenBond ReubenBond deleted the feature-testhost-netcore branch March 26, 2018 00:35
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ReubenBond @sergeybykov @galvesribeiro