Grain Call Filtering: discriminate InterfaceMethod and ImplementationMethod #4216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// <param name="services">The service collection.</param> | ||
| /// <param name="filter">The filter.</param> | ||
| /// <returns>The service collection.</returns> | ||
| internal static IServiceCollection AddIncomingGrainCallFilter(this IServiceCollection services, IIncomingGrainCallFilter filter) |
There was a problem hiding this comment.
please can you change these to public as they are currently not usable (same for the below), even in rc2
There was a problem hiding this comment.
@stephenlautier, I'll consider it since this seems to be a popular request. Can you use the methods on ISiloHostBuilder instead?
There was a problem hiding this comment.
Ahh oki, wasn't aware there was another way of doing it. My bad misread the Obsolete message and tried to use the internal instead. So its good enough, thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports #3480
See this comment for context: #3480 (comment)