Fix validator ordering #4211
Merged
Fix validator ordering #4211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Startup seems too late to me. I hope we can catch all validation errors at builder's build time. |
ReubenBond
approved these changes
Mar 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4203
The issue is that
SiloClusteringValidatorgetIMembershipOracleandIMembershipTablefrom DI, and they require themselves a lot of other components in DI...So if this validator is called before the validators from the options used in these membership constructors, it will fail without a good error message.
I think we should move these "advanced" check in the silo startup to avoid any trouble in the future, but for now it should fix the issue.