Improve usability of custom grain placement configuration #4102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-bot test functional |
sergeybykov
reviewed
Mar 5, 2018
| @@ -3,7 +3,7 @@ | |||
| namespace Orleans.Runtime | |||
| { | |||
| [Serializable] | |||
| internal class ActivationCountBasedPlacement : PlacementStrategy | |||
There was a problem hiding this comment.
What's the reason for making all these built-in strategies public? Seems like it's not something that application code will need to reference.
|
To expand on my comment. These are built-in placement policies, and I think it's a bad idea to let application code override their behavior because, for example, it would be very difficult to figure out in the logs why a well known placement strategy causes very different placement decisions. It is better to be explicit and introduce new strategies for new placement directors, so that there is no confusion. Hence, I think the built-in strategies should stay immutable. |
ReubenBond
force-pushed
the
fix-placement-registration
branch
from
6d2b4a4 to
f2d3bbe
Compare
|
All fixed :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4098