More options formatting, and related cleanup #3947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiazen
reviewed
Feb 2, 2018
| this.options = options; | ||
| } | ||
|
|
||
| protected List<string> FormatStatisticsOptions() |
There was a problem hiding this comment.
naming: FormatMessagingOptions
xiazen
approved these changes
Feb 2, 2018
Added formatters for grain directory options, grain placement options, schedualling options, thread pool options, type managment options, versioning options and silo options. Fixed formatting of messaging options. Fixed some options defaults.
Cleaned up registeration order, it seems options are logged in order of registeration (by default). Not an expected or necessary behavior.
jason-bragg
force-pushed
the
MoreOptionsFormatters
branch
from
5962494 to
3548522
Compare
jdom
reviewed
Feb 2, 2018
| @@ -25,4 +27,28 @@ public class SiloOptions | |||
| public bool FastKillOnCancelKeyPress { get; set; } = DEFAULT_FAST_KILL_ON_CANCEL; | |||
There was a problem hiding this comment.
not sure when this was added, but I wouldn't put this in Orleans' specific SiloOptions. We didn't copy everything related to IHost but the IHostLifetime already has things such as these when you use the ConsoleHostLifetime way of hosting... Not suggesting you copy everything related to that (or maybe you do want to), but at least keep it isolated, since it will go away when using Microsoft.Extensions.Hosting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added formatters for grain directory options, grain placement options, schedualling options, thread pool options, type managment options, versioning options and silo options.
Fixed formatting of messaging options.
Fixed some options defaults.