Fix Exception serialization on .NET Core #3794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdom
reviewed
Dec 14, 2017
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>netcoreapp2.0</TargetFramework> | |||
| <RuntimeFrameworkVersion>2.0.3</RuntimeFrameworkVersion> | |||
There was a problem hiding this comment.
hmmm, @attilah do you have a recommendation to avoid this? Because we are installing 2.0.3 if nothing is installed already, but if it is, then not sure whether this would break...
There was a problem hiding this comment.
I'd love to use a different solution if anyone has an idea of where to look.
ReubenBond
force-pushed
the
fix-netcore-exceptions
branch
from
7d17a10 to
62d2f18
Compare
ReubenBond
force-pushed
the
fix-netcore-exceptions
branch
from
62d2f18 to
bfa3535
Compare
|
@dotnet-bot test functional |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very small fix + some QoL test changes. I was unable to
dotnet xunitthe NetCore.Tests project without specifying<RuntimeFrameworkVersion>. It seems related to these three issues.Need to get NetCore.Tests running in CI - I'll experiment