Remove Bucket.TryCancel and use Bucket.TryRemove instead #3399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 13, 2017
sergeybykov
pushed a commit
to sergeybykov/orleans
that referenced
this pull request
Sep 29, 2017
jdom
pushed a commit
that referenced
this pull request
Sep 29, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3165 and #3352
When an
Activation.ScanAllis called, we do not remove theActivationDatafrom the bucket, instead we set the value tonull, that can causeNullReferenceExceptionwhen we iterate again theActivationDatafrom the bucket.I removed completely the
Bucket.TryCancelmethod and merged the logic inBucket.TryRemove. I am not sure what was the idea behind setting this to null instead of removing it (freeing some memory when iterating on the bucket?), but I don't think it was necessary.