Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add activate/deactivate to grain lifecycle #3385

Merged
merged 2 commits into from
Sep 8, 2017

Conversation

jason-bragg
Copy link
Contributor

No description provided.

@jason-bragg jason-bragg force-pushed the GrainLifecycleCleanup branch from ac2c383 to 491d6aa Compare September 7, 2017 18:38
Copy link
Member

@jdom jdom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for carrying out the previous feedback. Also wrt to simplifying to an int, it makes since much simpler for the end user.

SetupState, // Setup grain state prior to activation
//InvokeActivate,
SetupState = 1<<10, // Setup grain state prior to activation
Activate = SetupState + 1<<10, // Acivate grain
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in comment.
Nevertheless, please turn these into XML comments so that it helps with intellisense

@jdom jdom merged commit 1479bdf into dotnet:master Sep 8, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants