Fix NullReferenceException when no LogConsistencyProvider attribute is provided #3158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-bot test netstandard-win-bvt |
|
Thank you, @Liversage! |
sergeybykov
pushed a commit
that referenced
this pull request
Jul 3, 2017
jdom
pushed a commit
that referenced
this pull request
Jul 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a
LogConsistencyProvideris configured with the nameDefaultthen aJournaledGrainwithout aLogConsistencyProviderAttributewill use that provider. However, a bug in a logging statement resulted in aNullReferenceException. The name of the provider was retrieved from the variableattrthat isnullwhen no attribute is specified.The fix is to get the name of the provider from the provider itself.
It took me some time to pinpoint the location of this bug in the source code. Interestingly, when I opened the file in Visual Studio ReSharper flagged the exact statement I had located by code inspection with a green squiggly to indicate a possible
NullReferenceException.