Serialization test for JObject #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeybykov
added a commit
that referenced
this pull request
Apr 8, 2015
Serialization test for JObject
|
Fantastic, thank you! So the gist of the change is that you exposed the FindSerializationInfo method so that we can register our serializers during bootstrap. Looks good. |
|
There was no change @ReubenBond. I did NOT expose FindSerializationInfo method, it is still internal method. There was no code change required in Orleans, it worked correctly all the time. I just added a unit test that proves it works. |
|
Ha, even better 😊 my bad for not noticing |
|
No worries. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #299.