SMS: avoid copy in OnNextAsync if user has specified immutable data optimization #3058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiazen
reviewed
May 26, 2017
| { | ||
| // In order to avoid potential concurrency errors, synchronously copy the input before yielding the | ||
| // thread. DeliverItem below must also be take care to avoid yielding before copying for non-immutable objects. | ||
| item = (T) this.serializationManager.DeepCopy(item); |
There was a problem hiding this comment.
@jason-bragg you are correct after all. 💃
|
@jason-bragg please review asap so this goes in, since the current code is failing a test in most of our unrelated PRs |
sergeybykov
pushed a commit
to sergeybykov/orleans
that referenced
this pull request
May 31, 2017
jdom
pushed a commit
that referenced
this pull request
May 31, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a minor test breakage introduced in #3048.
A test was relying on data not being copied if the optimization for immutable data was set. In reality this isn't an issue, since we don't guarantee consumers and producers are on the same silo, but the fix is trivial. I didn't realize previously that this field was available, my mistake.