Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve service cleanup #2876

Merged
merged 3 commits into from
Mar 22, 2017
Merged

Improve service cleanup #2876

merged 3 commits into from
Mar 22, 2017

Conversation

jdom
Copy link
Member

@jdom jdom commented Mar 22, 2017

  • Dispose service provider when shutting down Silo and Client (which in turns disposes all disposable services in it).
  • Close log after fully shutting down.
  • Do not throw when calling Stop on AsynchQueueAgent after it was disposed.

@jdom
Copy link
Member Author

jdom commented Mar 22, 2017

Spin off to its own PR from #2856

@jdom jdom mentioned this pull request Mar 22, 2017
Merged
@ReubenBond ReubenBond merged commit 3479f7e into dotnet:master Mar 22, 2017
@jdom jdom deleted the service-cleanup branch March 22, 2017 22:35
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ReubenBond ReubenBond ReubenBond approved these changes

Assignees

@ReubenBond ReubenBond

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdom @ReubenBond @dnfclas