Fix mono/osx build and tests #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 2, 2016 22:49
Commit 8f27bba broke the mono build as a result of changed field/property names, which were being compiled only for `FEATURE_WIN32_REGISTRY`.
... generated app.config file. This caused test failures with mono/osx as it was running with `15.0` but the app.config had entries for `14.1` .
| @@ -581,12 +581,12 @@ public void ExtensionPathsTest_Basic1() | |||
| #if XPLAT | |||
There was a problem hiding this comment.
(discussion, doesn't need to be done now)
Should we remove this condition? It seems . . . imprecise, and I vaguely recall that it was mostly to reduce code churn caused by porting a feature that originated in xplat to master.
(I'm working on it!)
There was a problem hiding this comment.
Oh, you had to add the XPLAT define in this review. Then I think it should be removed entirely. If I'm reading the code right that shouldn't require any code change--it was just there to wall off the platform-detection methods that don't exist in master yet.
|
Thanks! Looks good once we just get rid of the |
... constant that is unnecessary now. "it was just there to wall off the platform-detection methods that don't exist in master yet." - Rainer
|
Removed |
|
Awesome. Looks good to me. @Microsoft/msbuild-maintainers ? |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.