Revert move of reference assemblies into obj #6718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladipro
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AB#1361354.
Work item (Internal use): AB#1361354
Summary
Revert changes to move reference assemblies to the obj folder, which appears to cause a not-yet-understood issue in Visual Studio scenarios.
Customer Impact
Reference assemblies will reappear in the
bin/folder as they were in prior releases.Regression?
Yes, from #6560.
Testing
Unit tests, manual patching of targets file in repro case with old copy resolves the issue.
Risk
Less testing on the new in-obj behavior.