Fix how ClickOnce handles developement dependency package references #6037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ies from inclusion in the ClickOnce manifest
rainersigwald
approved these changes
Jan 14, 2021
John-Hart
approved these changes
Jan 14, 2021
Forgind
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1257168
Context
Issue: ClickOnce is currently publishing contents of Nuget packages that are marked as developement dependencies. These package references should be excluded by publishing providers.
Changes Made
Filter out the development dependencies from the _DeploymentReferencePaths item group. The filtering happens by looking at the CopyToPublishDirectory attribute on ReferenceCopyLocalPaths group which is set to false for said packages.
Testing
CTI has validated specific packages that are affected and also validated the change against top 50 NuGet packages.
Notes