Fix double build Fixes #5830 #5838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Forgind would that fix this case too? https://developercommunity2.visualstudio.com/t/Build-solution-after-switching-configura/891400 |
|
@marcpopMSFT, it shouldn't. That customer was talking about configuration, whereas this is target framework. I'm a little surprised by their bug, since I would've thought they'd each go into their own folder (unless otherwise specified) and not overwrite each other. In any case, that sounds more like a FUTD check problem, whereas this isn't, I think. |
Fixes dotnet#5830. See explanation there.
Forgind
force-pushed
the
fix-double-build
branch
from
418daf7
to
db36b43
Compare
Forgind
commented
Nov 6, 2020
| @@ -1700,7 +1700,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. | |||
| If the NearestTargetFramework property was not set or the project has a single TargetFramework, we need to Undefine | |||
| TargetFramework to avoid another project evaluation. | |||
| --> | |||
| <AnnotatedProjects Condition="'@(AnnotatedProjects)' == '%(Identity)' and ('%(AnnotatedProjects.NearestTargetFramework)' == '' or '%(AnnotatedProjects.HasSingleTargetFramework)' == 'true')"> | |||
| <AnnotatedProjects Condition="('%(Extension)' == '.vcxproj' or '%(Extension)' == '.nativeproj') or ('@(AnnotatedProjects)' == '%(Identity)' and ('%(AnnotatedProjects.NearestTargetFramework)' == '' or '%(AnnotatedProjects.HasSingleTargetFramework)' == 'true'))"> | |||
There was a problem hiding this comment.
Put metadata on 1612 instead of doing this.
rainersigwald
approved these changes
Nov 6, 2020
| @@ -1609,6 +1609,7 @@ Copyright (C) Microsoft Corporation. All rights reserved. | |||
| <ItemGroup> | |||
| <_MSBuildProjectReferenceExistent Condition="'%(_MSBuildProjectReferenceExistent.SkipGetTargetFrameworkProperties)' == '' and ('%(Extension)' == '.vcxproj' or '%(Extension)' == '.nativeproj')"> | |||
| <SkipGetTargetFrameworkProperties>true</SkipGetTargetFrameworkProperties> | |||
| <UndefineProperties>%(_MSBuildProjectReferenceExistent.UndefineProperties);TargetFramework</UndefineProperties> | |||
There was a problem hiding this comment.
Since it took us so long to figure this out please comment this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.