-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 'WinFx' -> 'WinFX' casing #5346
Conversation
'WinFX' is the correct casing as observed in the .NET CLR 2 frameworks
'WinFX' is the correct casing as observed in the .NET CLR 2 frameworks
In project files, scripts, comments, etc...
for only previously changed files (in this Patch tree) Conforming to the repository's EditorConfig file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Microsoft.WinFx.targets
shipped with .NET Framework and is unlikely to be renamed/recase, I think we should match its shipped on-disk case, and propagate that case to our local shim copy. As a result, I don't think we should take this PR (even though the casing you propose is better to my eyes, too).
I'm not proposing a new case change. NETCLR 2 msbuild tools shipped with
These targets still have the correct casing though!
.NET Framework is Windows only and Case in-sensitive. Even though .NET Framework has high bar for compat, this doesn't seem to be a breaking change. This PR just matches them. I think It's OK to merge though. So, Can I ask Why? |
I don't know why it changed from .NET 3.5 to .NET 4.something. I agree that it shouldn't have--but at this point changing it back is not worth much and might break someone. I took a look around and this file is present in Mono installs on macOS (at least), so it can be present on a case-sensitive filesystem. Combined with the low impact of the change I don't think we should take this. Thanks for trying to clean this up! |
As the title suggests, This PR renames
WinFx
toWinFX
where possible.I've separated out the white-space changes to a separate commit.
Only files that were touched with
WinFX
casing changes are updated with formatting changes.If it's not possible to merge and/or if you want the line & space changes applied to the whole repo, please let me know, I'll separate these into a new PR.
Related: dotnet/wpf#2975