-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write generated AssemblyAttributes file to intermediate output path #5101
Conversation
@rainersigwald PTAL |
Can you explain why the old file location is a problem after dotnet/roslyn#39136? The test is failing on Mac and Linux with
I'm ok with conditionalizing the test to run only on Windows with a comment that it depends on .NET 4 targeting. |
Since the AssemblyAttributes file does not contain source for any method bodies it used to be not included in the document table in the PDB. With dotnet/roslyn#39136 the file is included in the PDB, which leads to more issues. For example, a deterministic build won't normalize random paths outside of the repo root, path to %temp% directory leaks the user name, etc. |
1576128
to
0a740bf
Compare
@rainersigwald The test now runs on Windows only. |
This got fixed in 2020 with dotnet/msbuild#5101
Fixes #1479 as suggested in the issue description.