Do not reveal implicit elements through RawXml #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial implementation caused errors when editing a project in Visual Studio. The Roslyn Project System uses Project.Xml.RawXml to decide what to show to the user, and handles edits by saving that file. When RawXml had _Implicit elements, that made the first save create an invalid project with a literal _Implicit attribute in its imports (as well as imports from both the Sdk attribute and the now-present Import elements). To fix this, do the same transformation for RawXml that was being done for Save.
AndyGerlicher
approved these changes
Nov 30, 2016
This was missed in e5c9de9.
cdmihai
reviewed
Nov 30, 2016
| @@ -1785,6 +1779,20 @@ public void Save(Encoding saveEncoding) | |||
| #endif | |||
| } | |||
|
|
|||
| private XmlDocument RemoveImplicits() | |||
There was a problem hiding this comment.
If this turns out to be a hot path, then the ProjectRootElement could be made aware if it has implicit elements and skip this call when it doesn't.
This fixes unit test failures that arose because cloning the XmlDocument caused a spurious `\n` character to be inserted after the XML declaration tag in the saved output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial implementation caused errors when editing a project in Visual
Studio. The Roslyn Project System uses Project.Xml.RawXml to decide what
to show to the user, and handles edits by saving that file. When RawXml
had _Implicit elements, that made the first save create an invalid project
with a literal _Implicit attribute in its imports (as well as imports from
both the Sdk attribute and the now-present Import elements).
To fix this, do the same transformation for RawXml that was being done for
Save.