[vs17.8] disallow inserting pkgs twice in VS insertion #11152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanProvaznik
changed the title
| @@ -56,6 +56,10 @@ parameters: | |||
| default: 183 | |||
| type: number | |||
| displayName: 'Drop Retention Days (do not set to < 90)' | |||
| - name: SkipUploadingPackages | |||
There was a problem hiding this comment.
Can you elaborate on why you prefer to have this granularity, instead of an input that directly controls allowPackageConflicts?
There was a problem hiding this comment.
I did not see a strong reason for either option. This seemed a tad more clear for the pipeline user and as a bonus it saves like 30s of the pipeline execution.
JanKrivanek
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11136
will propagate via mergeflow
Context
This prevents wrong behavior of the VS insertion with an override for edge cases.
Changes Made
Fail on package conflicts when pushing them to feeds and add an override parameter which skips the pushing stage
Testing
https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/results?buildId=10716305&view=results
Notes