Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmbeddedResource Culture Check #11023

Merged
merged 7 commits into from
Nov 27, 2024
Merged

EmbeddedResource Culture Check #11023

merged 7 commits into from
Nov 27, 2024

Conversation

JanKrivanek
Copy link
Member

@JanKrivanek JanKrivanek commented Nov 22, 2024

Fixes #9882, #9154

Context

This is the initial implementation of the EmbeddedResourceCheck class, which is a built-in analyzer that checks for the presence of the Culture metadata in EmbeddedResource items.

Testing

Tailored tests

Copy link
Member

@surayya-MS surayya-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

documentation/specs/BuildCheck/Codes.md Outdated Show resolved Hide resolved
src/BuildCheck.UnitTests/EndToEndTests.cs Show resolved Hide resolved
src/Build/BuildCheck/Checks/EmbeddedResourceCheck.cs Outdated Show resolved Hide resolved
src/Build/BuildCheck/Checks/EmbeddedResourceCheck.cs Outdated Show resolved Hide resolved
src/Shared/StringExtensions.cs Show resolved Hide resolved
@JanKrivanek JanKrivanek enabled auto-merge (squash) November 27, 2024 07:49
@JanKrivanek JanKrivanek merged commit bc2ad7f into main Nov 27, 2024
10 checks passed
@JanKrivanek JanKrivanek deleted the proto/embeddedresource-check branch November 27, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Built-in analyzer] EmbeddedResource item is missing the Culture metadata
4 participants