Added test to for ConfigurationContext #10535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuliiaKovalova
approved these changes
Aug 19, 2024
MichalPavlik
approved these changes
Aug 26, 2024
surayya-MS
approved these changes
Aug 26, 2024
| @@ -17,9 +17,19 @@ public sealed class Check1 : Check | |||
|
|
|||
| public override IReadOnlyList<CheckRule> SupportedRules { get; } = new List<CheckRule>() { SupportedRule }; | |||
|
|
|||
| private string message = "Argument for the message format"; | |||
| using (var env = TestEnvironment.Create()) | ||
| { | ||
| string checkCandidatePath = Path.Combine(TestAssetsRootPath, "CheckCandidate"); | ||
| string message = ": An extra message for the analyzer"; |
There was a problem hiding this comment.
nit: ": An extra message for the check"
| [Fact] | ||
| public void CheckHasAccessToAllConfigs() | ||
| { | ||
| using (var env = TestEnvironment.Create()) |
There was a problem hiding this comment.
why do you need env here and not the global _env?
| // Can't use Transitive environment due to the need to dogfood local nuget packages. | ||
| AddCustomDataSourceToNugetConfig(checkCandidatePath); | ||
| string editorConfigName = Path.Combine(checkCandidatePath, EditorConfigFileName); | ||
| File.WriteAllText(editorConfigName, ReadEditorConfig( |
There was a problem hiding this comment.
nit: i beleive you can use the existing ReadEditorConfig() method located in the same file EndToEndTests.cs in order to populate config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10291
Changes Made
Added test to see if Checks can access and use all configuration (custom and infra) available to them.