Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert Emit eval props if requested by any sink (#10243)" #10508

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

JanKrivanek
Copy link
Member

@JanKrivanek JanKrivanek commented Aug 12, 2024

Reverts #10447
Reintroduces changes from #10243
Fixes #10225

Context

#10243 introduced fix that ensured props/items attached to ProjectEvaluationFinishedEventargs if requested by any logger.
This however caused perf regression (https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/2173921) - as previously props/items were attached only when requested by ALL loggers. Such behavior would however break loggers requiring the props for correct functionality (e.g. BuildCheck logger).

VS insertions

@JanKrivanek JanKrivanek marked this pull request as ready for review August 13, 2024 13:20
@JanKrivanek JanKrivanek enabled auto-merge (squash) August 15, 2024 15:47
@JanKrivanek JanKrivanek merged commit befaec7 into main Aug 15, 2024
10 checks passed
@JanKrivanek JanKrivanek deleted the revert-10447-proto/revert-eval-props branch August 15, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VS Binlog has evaluations that don't include property/item data with MSBUILDLOGIMPORTS
3 participants