Revert "Revert Emit eval props if requested by any sink (#10243)" #10508
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #10447
Reintroduces changes from #10243
Fixes #10225
Context
#10243 introduced fix that ensured props/items attached to
ProjectEvaluationFinishedEventargs
if requested by any logger.This however caused perf regression (https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/2173921) - as previously props/items were attached only when requested by ALL loggers. Such behavior would however break loggers requiring the props for correct functionality (e.g. BuildCheck logger).
VS insertions