Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test deprecation comment on BuildItemGroup.cs #10166

Closed
wants to merge 1 commit into from

Conversation

JanKrivanek
Copy link
Member

Context

Sample deprecation comment to be used on public types in deprecated code

@JanKrivanek JanKrivanek requested a review from ghogen May 21, 2024 18:45
Comment on lines +19 to +23
/// <format type="text/markdown"><![CDATA[
/// > [!CAUTION]
/// > This class has been deprecated. Please use Microsoft.Build.Evaluation.ProjectCollection and related types from the Microsoft.Build assembly instead.
/// ]]>
/// </format>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this show up in IDEs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mainly ask because several years ago the F# community (including me) tried to strong-arm using markdown in triple-slash comments so that things would render more nicely in VSCode. These comments rendered wonderfully in VSCode without any additional work from the F# language services, but as you might expect VS and VSMac users had a severely degraded experience. We decided after 6 months or so of pushing that across a number of community libraries to instead work on improvements to the xml syntaxes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how it currently shows on VS 2022
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I was worried about :-/ That's quite cluttered in the VS view.

@JanKrivanek JanKrivanek mentioned this pull request May 23, 2024
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants