Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CoreCompileInputs.cache should be deleted on clean #1577

Closed
rainersigwald opened this issue Jan 17, 2017 · 3 comments
Closed

CoreCompileInputs.cache should be deleted on clean #1577

rainersigwald opened this issue Jan 17, 2017 · 3 comments
Labels
.NET Core triaged
Milestone
MSBuild 15.3

Comments

@rainersigwald
Copy link
Member

After #1327, the common targets emit a CoreCompileInputs.cache file to the obj directory, but don't add it to the right items to ensure it gets cleaned up on a full clean.
@rainersigwald rainersigwald added this to the Visual Studio 15 RTM milestone Jan 17, 2017
@rainersigwald
Copy link
Member Author

@AArnott noticed this in dotnet/sdk#650.

@rainersigwald rainersigwald mentioned this issue Jan 17, 2017
Closed
@AndyGerlicher AndyGerlicher modified the milestones: Visual Studio 15 RTW, MSBuild 15 Update Jan 24, 2017
This was referenced Feb 1, 2017
Closed
Closed
AndyGerlicher added a commit to AndyGerlicher/msbuild that referenced this issue Feb 23, 2017
@AndyGerlicher
Add CoreCompileInputs.cache to FileWrites
c13767d 
File will now be removed on /t:Clean

Closes dotnet#1577
@AndyGerlicher AndyGerlicher mentioned this issue Feb 23, 2017
Merged
AndyGerlicher added a commit that referenced this issue Feb 23, 2017
@AndyGerlicher
Add CoreCompileInputs.cache to FileWrites (#1741)
fdbf2d3 
File will now be removed on /t:Clean

Closes #1577
@cdmihai
Copy link
Contributor

cdmihai commented Mar 8, 2017 •
edited
Loading

Still reproes for full framework:

d:\projects\tests\projects\ConsoleApp1FullFramework\ConsoleApp1FullFramework>dir
 Volume in drive D is work
 Volume Serial Number is 4E01-2488

 Directory of d:\projects\tests\projects\ConsoleApp1FullFramework\ConsoleApp1FullFramework

03/08/2017  10:45 AM    <DIR>          .
03/08/2017  10:45 AM    <DIR>          ..
03/08/2017  10:37 AM               189 App.config
03/08/2017  10:37 AM             2,357 ConsoleApp1FullFramework.csproj
03/08/2017  10:37 AM               264 Program.cs
03/08/2017  10:37 AM    <DIR>          Properties
               3 File(s)          2,810 bytes
               3 Dir(s)  853,684,150,272 bytes free

d:\projects\tests\projects\ConsoleApp1FullFramework\ConsoleApp1FullFramework>msbuild /t:build /v:quiet
Microsoft (R) Build Engine version 15.1.548.43366
Copyright (C) Microsoft Corporation. All rights reserved.


d:\projects\tests\projects\ConsoleApp1FullFramework\ConsoleApp1FullFramework>msbuild /t:clean
Microsoft (R) Build Engine version 15.1.548.43366
Copyright (C) Microsoft Corporation. All rights reserved.

Build started 3/8/2017 10:46:39 AM.
Project "d:\projects\tests\projects\ConsoleApp1FullFramework\ConsoleApp1FullFramework\ConsoleApp1FullFramework.csproj"
on node 1 (clean target(s)).
CoreClean:
  Deleting file "d:\projects\tests\projects\ConsoleApp1FullFramework\ConsoleApp1FullFramework\bin\Debug\ConsoleApp1Full
  Framework.exe.config".
  Deleting file "d:\projects\tests\projects\ConsoleApp1FullFramework\ConsoleApp1FullFramework\bin\Debug\ConsoleApp1Full
  Framework.exe".
  Deleting file "d:\projects\tests\projects\ConsoleApp1FullFramework\ConsoleApp1FullFramework\bin\Debug\ConsoleApp1Full
  Framework.pdb".
  Deleting file "d:\projects\tests\projects\ConsoleApp1FullFramework\ConsoleApp1FullFramework\obj\Debug\ConsoleApp1Full
  Framework.csprojResolveAssemblyReference.cache".
  Deleting file "d:\projects\tests\projects\ConsoleApp1FullFramework\ConsoleApp1FullFramework\obj\Debug\ConsoleApp1Full
  Framework.exe".
  Deleting file "d:\projects\tests\projects\ConsoleApp1FullFramework\ConsoleApp1FullFramework\obj\Debug\ConsoleApp1Full
  Framework.pdb".
Done Building Project "d:\projects\tests\projects\ConsoleApp1FullFramework\ConsoleApp1FullFramework\ConsoleApp1FullFram
ework.csproj" (clean target(s)).


Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:00.12

d:\projects\tests\projects\ConsoleApp1FullFramework\ConsoleApp1FullFramework>tree /F /A obj
Folder PATH listing for volume work
Volume serial number is 4E01-2488
D:\PROJECTS\TESTS\PROJECTS\CONSOLEAPP1FULLFRAMEWORK\CONSOLEAPP1FULLFRAMEWORK\OBJ
\---Debug
        CoreCompileInputs.cache

For .net core console apps:

d:\projects\tests\projects\ConsoleApp1Core\ConsoleApp1Core>dir
 Volume in drive D is work
 Volume Serial Number is 4E01-2488

 Directory of d:\projects\tests\projects\ConsoleApp1Core\ConsoleApp1Core

03/08/2017  10:50 AM    <DIR>          .
03/08/2017  10:50 AM    <DIR>          ..
03/08/2017  10:43 AM               176 ConsoleApp1Core.csproj
03/08/2017  10:43 AM               195 Program.cs
               2 File(s)            371 bytes
               2 Dir(s)  853,684,477,952 bytes free

d:\projects\tests\projects\ConsoleApp1Core\ConsoleApp1Core>msbuild /t:restore /v:quiet
Microsoft (R) Build Engine version 15.1.548.43366
Copyright (C) Microsoft Corporation. All rights reserved.


d:\projects\tests\projects\ConsoleApp1Core\ConsoleApp1Core>msbuild /t:build /v:quiet
Microsoft (R) Build Engine version 15.1.548.43366
Copyright (C) Microsoft Corporation. All rights reserved.


d:\projects\tests\projects\ConsoleApp1Core\ConsoleApp1Core>msbuild /t:clean
Microsoft (R) Build Engine version 15.1.548.43366
Copyright (C) Microsoft Corporation. All rights reserved.

Build started 3/8/2017 10:50:52 AM.
Project "d:\projects\tests\projects\ConsoleApp1Core\ConsoleApp1Core\ConsoleApp1Core.csproj" on node 1 (clean target(s)).
CoreClean:
  Deleting file "d:\projects\tests\projects\ConsoleApp1Core\ConsoleApp1Core\bin\Debug\netcoreapp1.1\ConsoleApp1Core.deps.json".
  Deleting file "d:\projects\tests\projects\ConsoleApp1Core\ConsoleApp1Core\bin\Debug\netcoreapp1.1\ConsoleApp1Core.runtimeconfig.json".
  Deleting file "d:\projects\tests\projects\ConsoleApp1Core\ConsoleApp1Core\bin\Debug\netcoreapp1.1\ConsoleApp1Core.runtimeconfig.dev.json".
  Deleting file "d:\projects\tests\projects\ConsoleApp1Core\ConsoleApp1Core\bin\Debug\netcoreapp1.1\ConsoleApp1Core.dll".
  Deleting file "d:\projects\tests\projects\ConsoleApp1Core\ConsoleApp1Core\bin\Debug\netcoreapp1.1\ConsoleApp1Core.pdb".
  Deleting file "d:\projects\tests\projects\ConsoleApp1Core\ConsoleApp1Core\obj\Debug\netcoreapp1.1\ConsoleApp1Core.csprojResolveAssemblyReference.cache".
  Deleting file "d:\projects\tests\projects\ConsoleApp1Core\ConsoleApp1Core\obj\Debug\netcoreapp1.1\ConsoleApp1Core.AssemblyInfo.cs".
  Deleting file "d:\projects\tests\projects\ConsoleApp1Core\ConsoleApp1Core\obj\Debug\netcoreapp1.1\ConsoleApp1Core.dll".
  Deleting file "d:\projects\tests\projects\ConsoleApp1Core\ConsoleApp1Core\obj\Debug\netcoreapp1.1\ConsoleApp1Core.pdb".
Done Building Project "d:\projects\tests\projects\ConsoleApp1Core\ConsoleApp1Core\ConsoleApp1Core.csproj" (clean target(s)).


Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:00.38

d:\projects\tests\projects\ConsoleApp1Core\ConsoleApp1Core>tree /F /A obj
Folder PATH listing for volume work
Volume serial number is 4E01-2488
D:\PROJECTS\TESTS\PROJECTS\CONSOLEAPP1CORE\CONSOLEAPP1CORE\OBJ
|   ConsoleApp1Core.csproj.nuget.g.props
|   ConsoleApp1Core.csproj.nuget.g.targets
|   project.assets.json
|
\---Debug
    \---netcoreapp1.1
            CoreCompileInputs.cache

@cdmihai cdmihai reopened this Mar 8, 2017
@cdmihai
Copy link
Contributor

cdmihai commented Mar 8, 2017

Nuget issue tracked at NuGet/Home#4476
MSBuild issue did not flow in VS yet.

@cdmihai cdmihai closed this as completed Mar 8, 2017
@Sarabeth-Jaffe-Microsoft Sarabeth-Jaffe-Microsoft removed this from the MSBuild 15.2 milestone Mar 24, 2017
@forki forki mentioned this issue Oct 12, 2017
Closed
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
.NET Core triaged
Projects
None yet
Milestone
MSBuild 15.3
Development

No branches or pull requests
5 participants
@cdmihai @rainersigwald @AndyGerlicher @Sarabeth-Jaffe-Microsoft @AR-May