Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RemoveFromXml() throws on implicit element #1445

Closed
rainersigwald opened this issue Dec 6, 2016 · 1 comment
Closed

RemoveFromXml() throws on implicit element #1445

rainersigwald opened this issue Dec 6, 2016 · 1 comment
Labels
triaged
Milestone
Feature: Sdks

Comments

@rainersigwald
Copy link
Member

When you call ProjectRootElement.RemoveAllChildren() on a project that uses an Sdk (and thus has implicit imports), RemoveFromXml throws when it encounters the implicit Import element.
@rainersigwald
Copy link
Member Author

Repro is slightly more complicated: this only happens after being cloned into.

rainersigwald added a commit to rainersigwald/msbuild that referenced this issue Dec 6, 2016
@rainersigwald
Regression test for dotnet#1445
2ca4d2d 
Simulates the Roslyn Project System's "Reloadable projects" feature that
is used to edit a project without unloading it from VS first.
This was referenced Dec 6, 2016
Closed
Merged
@AndyGerlicher AndyGerlicher added this to the Feature: Sdks milestone Dec 6, 2016
@rainersigwald rainersigwald mentioned this issue Dec 7, 2016
Merged
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triaged
Projects
None yet
Milestone
Feature: Sdks
Development

No branches or pull requests
3 participants
@rainersigwald @AndyGerlicher @AR-May