Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 17.12 #10665

Closed
44 of 45 tasks
Tracked by #10592
maridematte opened this issue Sep 16, 2024 · 0 comments
Closed
44 of 45 tasks
Tracked by #10592

Release 17.12 #10665

maridematte opened this issue Sep 16, 2024 · 0 comments
Assignees
Labels

Comments

@maridematte
Copy link
Contributor

maridematte commented Sep 16, 2024

MSBuild Release Checklist 17.12

At any time

  • Create a new issue to track the release checklist, with this checklist copied into the issue.
    • Replace 17.11 with the previous release version, for example 17.9
    • Replace 17.12 with the current release version, for example 17.10
    • Replace 17.13? with the next release version, for example 17.11
  • Create vs17.12 branch
  • Create darc channel for VS 17.13? if it doesn't already exist
    darc add-channel --name "VS 17.13"
  • Ping internal "First Responders" Teams channel to get the new channel made available as a promotion target (e.g. Make "VS 17.6" darc channel promotionable arcade#12150): Make VS 17.13 channel promotable arcade#15099

At release time

  • If the release is being cut more than a few days before the VS-side snap, do these two steps. Otherwise check them off.
    • Modify the VS insertion so that it flows from MSBuild vs17.12 to VS main in the MSBuild-release-branch release definition. Alternatively, if the release being cut no more than couple of weeks, disable the scheduled releases and create releases from vs17.12 manually until the VS-side snap: Edit -> Schedule set under Artifacts -> disable toggle
      AND
    • Disable automated run of the MSBuild-main-branch release definition (because our 17.13 builds don't have a place to go in VS yet)
  • Remove the main to old release channel (17.12) default channel
    darc delete-default-channel --repo https://github.com/dotnet/msbuild --branch main --channel "VS 17.12"
  • Associate the main branch with the next release channel
    darc add-default-channel --channel "VS 17.12" --branch main --repo https://github.com/dotnet/msbuild
  • Check subscriptions for the forward-looking channel VS 17.13 and update as necessary (for instance, SDK's main branch should usually be updated, whereas release branches often should not be
    darc get-subscriptions --exact --source-repo https://github.com/dotnet/msbuild --channel "VS 17.12"
  • Update channel VS 17.12 to VS 17.13 for the sdk main subscription and any others from the previous step
    darc update-subscription --id sdk_main_branch_id
  • Ensure that the current release channel VS 17.12 is associated with the correct release branch
    darc get-default-channels --source-repo https://github.com/dotnet/msbuild --branch vs17.12
    if it is not, darc add-default-channel --channel "VS 17.12" --branch vs17.12 --repo https://github.com/dotnet/msbuild
  • If the branch was created before the fork: fast-forward merge the correct commit (the one that is currently inserted to VS main) to the vs17.12 branch
    e.g.: git push upstream 2e6f2ff7ea311214255b6b2ca5cc0554fba1b345:refs/heads/vs17.10
    (This is for the case where we create the branch too early and want it to be based actually on a different commit. If you waited until a good point in time with main in a clean state, just branch off and you are done. The branch should point to a good, recent spot, so the final-branding PR goes in on top of the right set of commits.)
  • Update the branch merge flow in .config/git-merge-flow-config.jsonc file to have the currently-in-servicing branches.
  • Fix OptProf data flow for the new vs17.12 branch
    • Run the official build for vs17.12 without OptProf (set SkipApplyOptimizationData variable in 'Advanced options' section of the 'Run pipeline' menu to true) or alternatively with the latest Opt-Prof collected for the main branch (set Optional OptProfDrop Override to the drop path of the collected data, which could be found in the logs of the pipeline: Windows_NT -> Build -> search for OptimizationData).
    • Check that the OptProf data collection pipeline run is triggered for vs17.12. If not, run manually ('Run pipeline' in upper right)
    • Run the official build for vs17.12 with no extra customization - OptProf should succeed now
  • Create 17.13 branding PR (in main) including public API baseline package version change: Branding for 17.13 #10703. In the file eng/Versions.props Update the VersionPrefix to 17.13 and PackageValidationBaselineVersion set to a latest internally available 17.12 preview version in the internal dnceng dotnet-tools feed. It might be needed to update CompatibilitySuppressions.xml files. See this documentation for more details. You can update CompatibilitySuppressions.xml files by running
    dotnet pack MSBuild.Dev.slnf /p:ApiCompatGenerateSuppressionFile=true.
  • Create 17.12 localization ticket: https://aka.ms/ceChangeLocConfig (requesting to switch localization from 17.11 to 17.12): https://ceapex.visualstudio.com/CEINTL/_workitems/edit/1000990
  • Enable 17.12 localization - by setting EnableReleaseOneLocBuild to true
  • Disable 17.11 localization - by setting EnableReleaseOneLocBuild to false. Update the comment on the same line.
  • Merge 17.13 branding PR: Branding for 17.13 #10703
  • Create and merge a PR in main to update a localization version comment in setting EnableReleaseOneLocBuild to set up the merge conflict when this line will be updated in the release branch.
  • When VS main snaps to 17.12 and updates its version to 17.13, turn on / modify the VS insertion so that it flows from MSBuild main to VS main.
  • Update the release-branch insertion release definition to have InsertTargetBranch rel/d17.12.
  • Turn the release pipeline back on.
  • Prepare final branding PR for vs17.12: Add final branding VS17.12 #10697
  • Merge final branding to vs17.12 branch
  • Update perfstar MSBuild insertions configuration: example PR: {{URL_OF_PERFSTAR_PR}}
  • Note down the build (will be helpful for requesting nuget packages publishing): (https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/586458)
  • Get M2 or QB approval as necessary per the VS schedule
  • Merge to VS (babysit the automatically generated VS insertion PR https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequests for the MSBuild commit noted in above step): {{URL_OF_VS_INSERTION}}
  • Update the PackageValidationBaselineVersion to the latest released version (17.12.0) - this might require temporary addition of the build artifacts feed as the new version is not yet added to the official feeds (this is post release). This can trigger a high severity CG error (https://eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-docs/secure-supply-chain/how-to-securely-configure-package-source-files) - however it should be fine to keep this temporary feed untill the release.
  • Update the requested SDK version for bootstrap folder (the BootstrapSdkVersion property in Versions.props) and buildToolCommand/_InitializeBuildToolCommand values in cibuild_bootstrapped_msbuild scripts if a fresh sdk was released (released runtimes and associated sdk versions can be checked here - https://dotnet.microsoft.com/download/visual-studio-sdks - make sure to always check the details of the appropriate targeted version of .NET for the matching latest version of SDK).

ASAP On/After GA:

Timing based on the (Microsoft-internal) release schedule.

  • Push packages to nuget.org (not currently automated, contact dnceng - search "Publish MSBuild 17.6 to NuGet.org" email subject for template).
  • Publish docs: submit reference request at https://aka.ms/publishondocs
  • Remove the temporarily added build feed from nuget.config if it was added in the Update the PackageValidationBaselineVersion step
  • Update main subscriptions to the new channel (this can be done before or after release - depending on when the source repos from our previous - VS 17.12 - channle start to publish in the next - VS 17.13 - channel)
    darc get-subscriptions --exact --target-repo https://github.com/dotnet/msbuild --target-branch main
  • Create the 17.12 release
    • Create tag (can be done upfront)
    git checkout <commit noted above>
    git tag v17.12.3
    git push upstream v17.12.3
    
@maridematte maridematte self-assigned this Sep 16, 2024
@AR-May AR-May added the triaged label Sep 17, 2024
JaynieBai pushed a commit that referenced this issue Sep 24, 2024
Part of: #10665

Updating the localization comment so changes do not get merged automatically.
maridematte added a commit that referenced this issue Sep 25, 2024
Part of: #10665

Updating branch flow from 17.11 -> 17.12 -> main.
maridematte added a commit that referenced this issue Sep 25, 2024
Part of: #10665

Disabling localization for 17.11.
maridematte added a commit that referenced this issue Sep 25, 2024
Part of #10665

Final branding for VS17.12.
@YuliiaKovalova YuliiaKovalova self-assigned this Oct 1, 2024
@maridematte maridematte removed their assignment Oct 8, 2024
JanKrivanek pushed a commit that referenced this issue Dec 10, 2024
* Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 10000931 (#10267)

* Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 9752299
* Increase VersionPrefix version

---------

Co-authored-by: Jenny Bai <[email protected]>

* [17.11] Fix component governance alerts (#10520)

* Resolves CG alerts
---------

Co-authored-by: Rainer Sigwald <[email protected]>

* Assembly redirect fix (#10624)

* Fixing the assembly redirect

* [vs17.11] Update dependencies from dotnet/arcade (#10654)

* Update dependencies from https://github.com/dotnet/arcade build 20240910.4

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.24311.3 -> To Version 8.0.0-beta.24460.4

* version bump

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Mariana Garces Dematte <[email protected]>

* Upgrade system.text.json to 8.0.4 (#10650)

Will address dotnet/sdk#43339 when deployed in VS.

---------

Co-authored-by: Rainer Sigwald <[email protected]>

* disable loc (#10693)

Part of: #10665

Disabling localization for 17.11.

* [vs17.11] Update dependencies from dotnet/arcade (#10691)

* [vs17.11] Update dependencies from dotnet/arcade (#10793)

* Update dependencies from https://github.com/dotnet/arcade build 20241008.1

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.24475.3 -> To Version 8.0.0-beta.24508.1

* bump the version

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: YuliiaKovalova <[email protected]>

* CG alert cleaning on VS17.11 (#10723)

* Bump Microsoft.IO.Redist to 6.0.1
* Bump version prefix to 17.11.11

* [vs17.11] Update dependencies from dotnet/arcade (#10832)

* [vs17.11] Update dependencies from dotnet/arcade (#10895)

* [vs17.11] Update dependencies from dotnet/arcade (#10990)

* Update dependencies from https://github.com/dotnet/arcade build 20241112.12

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.24525.2 -> To Version 8.0.0-beta.24562.12

* Update VersionPrefix to 17.11.16

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Gang Wang <[email protected]>

* Update dependencies from https://github.com/dotnet/arcade build 20241120.5

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.24562.12 -> To Version 8.0.0-beta.24570.5

* Update VersionPrefix to 17.11.17

* [vs17.11] Run tests even if version is not bumped (#11060)

Backport of #11042 to vs17.11

* [vs17.11] Backport VS insertion pipeline YMLs (#11064)

Co-authored-by: Jan Provaznik <[email protected]>

* Eliminate the unnecessary change from vs17.11

* Remove duplicate version setting for System.Formats.Asn1

* Bump up version prefix to 17.12.18

---------

Co-authored-by: dotnet bot <[email protected]>
Co-authored-by: Jenny Bai <[email protected]>
Co-authored-by: MichalPavlik <[email protected]>
Co-authored-by: Rainer Sigwald <[email protected]>
Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Mariana Garces Dematte <[email protected]>
Co-authored-by: YuliiaKovalova <[email protected]>
Co-authored-by: Gang Wang <[email protected]>
Co-authored-by: Surayya Huseyn Zada <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jan Provaznik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants