Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider scope of MSBuildDebugEngine #10639

Closed
rainersigwald opened this issue Sep 10, 2024 · 0 comments · Fixed by #10868
Closed

Reconsider scope of MSBuildDebugEngine #10639

rainersigwald opened this issue Sep 10, 2024 · 0 comments · Fixed by #10868
Assignees
@maridematte
Labels
Area: Debuggability Issues impacting the diagnosability of builds, including logging and clearer error messages. Area: Engine Issues impacting the core execution of targets and tasks. Cost:S Work that requires one engineer up to 1 week internal-team-onboarding Priority:2 Work that is important, but not critical for the release triaged

Comments

@rainersigwald
Copy link
Member

Right now MSBuildDebugEngine turns on three things:

  1. Injected binlogs for all evaluations and builds.
  2. MSBUILDDEBUGCOMM traces for node-connectivity debugging
  3. MSBUILDDEBUGSCHEDULER traces for scheduler debugging.

msbuild/src/Framework/Traits.cs

Lines 33 to 34 in 371d00f

DebugScheduler = DebugEngine || !string.IsNullOrEmpty(Environment.GetEnvironmentVariable("MSBUILDDEBUGSCHEDULER"));
DebugNodeCommunication = DebugEngine || !string.IsNullOrEmpty(Environment.GetEnvironmentVariable("MSBUILDDEBUGCOMM"));

Binlogs are super useful, and the reason we ask for this in like 99% of cases.

Comm traces can be helpful if we're having trouble with process launching or named pipes.

Scheduler traces . . . I can't remember ever getting useful info out of.

Should we drop scheduler traces from this list?
@rainersigwald rainersigwald added Area: Debuggability Issues impacting the diagnosability of builds, including logging and clearer error messages. Area: Engine Issues impacting the core execution of targets and tasks. Priority:2 Work that is important, but not critical for the release labels Sep 10, 2024
@rainersigwald rainersigwald mentioned this issue Sep 10, 2024
Closed
@maridematte maridematte self-assigned this Oct 8, 2024
@maridematte maridematte added the Cost:S Work that requires one engineer up to 1 week label Oct 8, 2024
@maridematte maridematte mentioned this issue Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maridematte maridematte

Labels
Area: Debuggability Issues impacting the diagnosability of builds, including logging and clearer error messages. Area: Engine Issues impacting the core execution of targets and tasks. Cost:S Work that requires one engineer up to 1 week internal-team-onboarding Priority:2 Work that is important, but not critical for the release triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed scheduler debugger from MSBuildDebugEngine maridematte/msbuild
3 participants
@rainersigwald @maridematte @AR-May