Skip to content

Commit

Permalink
Fix nullables after rebase
Browse files Browse the repository at this point in the history
  • Loading branch information
JanKrivanek committed Jun 6, 2024
1 parent 158375a commit e6771c4
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/Build/BackEnd/BuildManager/BuildManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2945,11 +2945,11 @@ private ILoggingService CreateLoggingService(

// We need to register SOME logger if we don't have any. This ensures the out of proc nodes will still send us message,
// ensuring we receive project started and finished events.
static List<ForwardingLoggerRecord> ProcessForwardingLoggers(IEnumerable<ForwardingLoggerRecord> forwarders)
static List<ForwardingLoggerRecord> ProcessForwardingLoggers(IEnumerable<ForwardingLoggerRecord>? forwarders)
{
Type configurableLoggerType = typeof(ConfigurableForwardingLogger);
string engineAssemblyName = configurableLoggerType.GetTypeInfo().Assembly.GetName().FullName;
string configurableLoggerName = configurableLoggerType.FullName;
string configurableLoggerName = configurableLoggerType.FullName!;

if (forwarders == null)
{
Expand All @@ -2968,7 +2968,7 @@ static List<ForwardingLoggerRecord> ProcessForwardingLoggers(IEnumerable<Forward

// Those are the cases where we are sure that we have the forwarding setup as need.
if (result.Any(l =>
l.ForwardingLoggerDescription.Name.Contains(typeof(CentralForwardingLogger).FullName)
l.ForwardingLoggerDescription.Name.Contains(typeof(CentralForwardingLogger).FullName!)
||
(l.ForwardingLoggerDescription.Name.Contains(configurableLoggerName)
&&
Expand All @@ -2983,7 +2983,7 @@ static List<ForwardingLoggerRecord> ProcessForwardingLoggers(IEnumerable<Forward
}

// In case there is a ConfigurableForwardingLogger, that is not configured as we'd need - we can adjust the config
ForwardingLoggerRecord configurableLogger = result.FirstOrDefault(l =>
ForwardingLoggerRecord? configurableLogger = result.FirstOrDefault(l =>
l.ForwardingLoggerDescription.Name.Contains(configurableLoggerName));

// If there is not - we need to add our own.
Expand Down

0 comments on commit e6771c4

Please sign in to comment.