Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0.5xx-sr5] Update dependencies from xamarin/xamarin-android #9991

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Sep 8, 2022

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.Dotnet.Sdk.Internal: from 6.0.401-servicing.22419.11 to 6.0.402-servicing.22457.1 (parent: Microsoft.Android.Sdk.Windows)

From https://github.com/xamarin/xamarin-android

  • Subscription: 788b31a1-6686-4f8f-8ec0-08da91238ed9
  • Build: 6.0.4xx-04623cdc317c3da5efce46cb16d94befe4833125-1
  • Date Produced: September 7, 2022 9:58:12 PM UTC
  • Commit: 04623cdc317c3da5efce46cb16d94befe4833125
  • Branch: refs/heads/release/6.0.4xx

…uild 6.0.4xx-04623cdc317c3da5efce46cb16d94befe4833125-1

Microsoft.Android.Sdk.Windows
 From Version 32.0.465 -> To Version 32.0.468

Dependency coherency updates

Microsoft.Dotnet.Sdk.Internal
 From Version 6.0.401-servicing.22419.11 -> To Version 6.0.402-servicing.22457.1 (parent: Microsoft.Android.Sdk.Windows
@ghost ghost added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label Sep 8, 2022
@mattleibow mattleibow added the do-not-merge Don't merge this PR label Sep 8, 2022
@mattleibow
Copy link
Member

This issue has a description of another issue (cheese was just moved) dotnet/android#7302 (comment)

@rmarinho
Copy link
Member

@mattleibow @jonathanpeppers why is this a do-not-merge, reading the issue on xamarin-android seems the fix is not done yet?

@jonathanpeppers
Copy link
Member

The fixes on xamarin-android/release/6.0.4xx will ship in the next service release and/or next .NET 7 release.

I think we've already branched/prepped the next MAUI build, so I don't see why you wouldn't merge this?

@mattleibow
Copy link
Member

This is in the SR5 branch, are we sure we want this here or in SR6? I recall you said this fixes a bug, but not actually so you need some runtime changes?

@mattleibow mattleibow marked this pull request as draft September 12, 2022 21:49
@jonathanpeppers
Copy link
Member

I would put this on the equivalent of your release/6.0.4xx branch. So it would go in the next .NET 6 service release.

@mattleibow mattleibow closed this Sep 13, 2022
@mattleibow mattleibow deleted the darc-release/6.0.5xx-sr5-55ef2bd4-5e77-48b5-9126-6cb17cefd365 branch September 13, 2022 01:19
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions do-not-merge Don't merge this PR platform/android 🤖
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants