Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Branch #838

Closed
wants to merge 13 commits into from
Closed

Update Branch #838

wants to merge 13 commits into from

Conversation

mattleibow
Copy link
Member

Description of Change

Implements #

Additions made

  • Adds

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

  • Does this PR introduce a new control? (If yes, add an example using SemanticProperties to the SemanticsPage)
  • APIs that modify focusability?
  • APIs that modify any text property on a control?
  • Does this PR modify view nesting or view arrangement in anyway?
  • Is there the smallest possibility that your PR will change accessibility?
  • I'm not sure, please help me

If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.

jsuarezruiz and others added 13 commits April 23, 2021 18:44
@jsuarezruiz @rmarinho
Implement MaxLength property in WinUI EntryHandler (#817)
fb828e9 
Co-authored-by: Rui Marinho <[email protected]>
@jsuarezruiz @rachelkang
Implement CharacterSpacing property in WinUI SearchBarHandler (#740)
77fe6e0 
* Implement CharacterSpacing property in WinUI SearchBarHandler

* Fix build error

Co-authored-by: Rachel Kang <[email protected]>
@jsuarezruiz @rmarinho
Implement IsReadOnly property in WinUI EntryHandler (#818)
0d36584 
Co-authored-by: Rui Marinho <[email protected]>
@jonathanpeppers
[singleproject] fix @(MauiSplashScreen) on iOS (#830)
28a97a2 
On iOS if you have a project with:

    <MauiSplashScreen Include="foo.svg" Color="Red" />

The color red displays, but the image is missing?

However, a project like this works fine:

    <MauiSplashScreen Include="foo.svg" Color="Red" />
    <MauiImage Include="foo.svg" />

It turns out that targets were running in the order:

    Target Name=ResizetizeCollectItems Project=SplashDemo.csproj
    Target Name=ResizetizeImages Project=SplashDemo.csproj
    Target Name=ProcessMauiSplashScreens Project=SplashDemo.csproj
    Target Name=ProcessMauiFonts Project=SplashDemo.csproj

`ProcessMauiSplashScreens` adds the splash screen to `@(MauiImage)`,
so we need to make sure `ProcessMauiSplashScreens` runs before
`ResizetizeImages`.

For iOS the build ordering is slightly different than Android, which
is why it appears to work without this change on Android.

It also worked in the samples I tried, because I was using the app
icon foreground as the splash screen image:

    <MauiImage Include="Resources\AppIcons\appicon.svg" ForegroundFile="Resources\AppIcons\appicon_foreground.svg" IsAppIcon="true" />
    <MauiSplashScreen Include="Resources\AppIcons\appicon_foreground.svg" Color="#FF69B4" />
@jsuarezruiz @rmarinho
Implement Date property in WinUI DatePickerHandler (#723)
d8634c4 
* Implement Date property in WinUI DatePickerHandler

* Fix build error

Co-authored-by: Rui Marinho <[email protected]>
@jsuarezruiz @rmarinho
Implement Time property in WinUI TimePickerHandler (#722)
6de2580 
* Implement Time property in WinUI TimePickerHandler

* Fix build error

Co-authored-by: Rui Marinho <[email protected]>
@github-actions
Automated dotnet-format update (#834)
71895a1 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@jsuarezruiz @rmarinho @rachelkang
Implement Placeholder property in WinUI EntryHandler (#819)
37ac37d 
* Implement Placeholder property in WinUI EntryHandler

* Update TextBoxExtensions.cs

Co-authored-by: Rui Marinho <[email protected]>
Co-authored-by: Rachel Kang <[email protected]>
@jsuarezruiz @rmarinho
Implement basic SliderHandler properties in WinUI (#718)
724bc0c 
* Implement basic Slider properties in WinUI

* Fix build error

* Fix build error

Co-authored-by: Rui Marinho <[email protected]>
@rmarinho
Update GitInfo on main (#835)
22a9e6a 
* Update GitInfo

* Update CI to build releases branches
@pjcollins @rmarinho
[build] Update to .NET 6 Preview 4 (#796)
720a338 
* [build] Update to .NET 6 Preview 4

Brings in Preview 4 updates for the Android, MaciOS, and .NET SDks.

Initial build attempts were failing with hundreds of errors:

    D:\a\1\s\src\Essentials\src\Connectivity\Connectivity.ios.tvos.macos.cs(12,70): error BI1234: 'CTCellularData' is obsolete: 'Starting with ios14.0 Use the 'CallKit' API instead.' [D:\a\1\s\src\Essentials\src\Essentials-net6.csproj]
    D:\a\1\s\src\Essentials\src\Compass\Compass.ios.cs(31,6): error CA1416: This call site is reachable on: 'iOS' 13.6 and later. 'CLLocationManager.HeadingFilter' is only supported on: 'macos' 11.0 and later. [D:\a\1\s\src\Essentials\src\Essentials-net6.csproj]
    D:\a\1\s\src\Core\src\Platform\MaciOS\ColorExtensions.cs(64,13): error CA1416: This call site is reachable on: 'MacCatalyst' 13.5 and later. 'UIColor.SystemBackgroundColor.get' is supported on: 'ios' 13.0 and later. [D:\a\1\s\src\Core\src\Core-net6.csproj]
    CSC : error AD0001: Analyzer 'Microsoft.NetCore.Analyzers.InteropServices.PlatformCompatibilityAnalyzer' threw an exception of type 'System.NullReferenceException' with message 'Object reference not set to an instance of an object.'. [D:\a\1\s\src\BlazorWebView\src\core\Microsoft.AspNetCore.Components.WebView.Maui.csproj]

The [platform compatibility analyzer][0] has been disabled for now, and
it can be enabled locally to work through the few hundred errors in
future PRs.

Once these issues were sorted, there were a handful of other breaks
that I've attempted to fix:

    D:\a\1\s\src\Essentials\src\AssemblyInfo\AssemblyInfo.ios.tvos.watchos.macos.cs(3,12): error CS0618: 'LinkerSafeAttribute' is obsolete: 'Replace with '[assembly: System.Reflection.AssemblyMetadata ("IsTrimmable", "True")]'.' [D:\a\1\s\src\Essentials\src\Essentials-net6.csproj]

    D:\a\1\s\src\Compatibility\Core\src\iOS\Renderers\TabbedRenderer.cs(422,33): error CS1503: Argument 1: cannot convert from 'UIKit.UIStringAttributes' to 'UIKit.UITextAttributes' [D:\a\1\s\src\Compatibility\Core\src\Compatibility-net6.csproj]

    D:\a\1\s\src\Compatibility\Core\src\iOS\CollectionView\CarouselViewController.cs(106,23): error CS0114: 'CarouselViewController.DraggingStarted(UIScrollView)' hides inherited member 'UICollectionViewController.DraggingStarted(UIScrollView)'. To make the current member override that implementation, add the override keyword. Otherwise add the new keyword. [ D:\a\1\s\src\Compatibility\Core\src\Compatibility-net6.csproj]
    D:\a\1\s\src\Compatibility\Core\src\iOS\CollectionView\CarouselViewController.cs(117,23): error CS0114: 'CarouselViewController.DraggingEnded(UIScrollView, bool)' hides inherited member 'UICollectionViewController.DraggingEnded(UIScrollView, bool)'. To make the current member override that implementation, add the override keyword. Otherwise add the new keyword. [ D:\a\1\s\src\Compatibility\Core\src\Compatibility-net6.csproj]

Finally it seems JDK 14 was being preferred on macOS machines in CI, so
I've set `$(JI_JAVA_HOME)` to the [pre-installed JDK 11][1].

[0]: https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1416
[1]: https://github.com/actions/virtual-environments/blob/macOS-10.15/20210419.2/images/macos/macos-10.15-Readme.md#java

* Apply feedback, bump p4 bits, provision xcode 12.5 rc

* Use Big Sur pool, clean up duplicate variable declaration

* Revert "Use Big Sur pool, clean up duplicate variable declaration"

This reverts commit b91482e.

* Disable linker for ios and catalyst

Co-authored-by: Rui Marinho <[email protected]>
@rmarinho
Fix yaml triggers
864eb33
@rmarinho
Run pr's for release branches
80abddd
@mattleibow mattleibow closed this Apr 24, 2021
@samhouts samhouts added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label Jul 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mattleibow @samhouts @jsuarezruiz @jonathanpeppers @rmarinho @pjcollins