-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[net7] include net6 templates #8203
Merged
Merged
Changes from 24 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
dc98b32
Include net6 template packs in net7 workload
Redth d5c81d8
Previous template pack version
Redth af08b6a
Fix bad copy pasta
Redth f959933
Merge remote-tracking branch 'origin/net7.0' into net7-include-net6-t…
mattleibow e976635
More template tests
mattleibow 11cfe15
Merge branch 'net7.0' into net7-include-net6-templates
mattleibow 9b5d151
Merge remote-tracking branch 'origin/net7.0' into net7-include-net6-t…
mattleibow 39056fd
Make --framework and -f work!
mattleibow 92d9a6c
Swap the values in the cli file as well
mattleibow eb7e578
--Framework for now
mattleibow beae459
Merge branch 'net7.0' into net7-include-net6-templates
mattleibow 847c714
?:
mattleibow fa16f28
This should be working now
mattleibow 952739f
revert that
mattleibow 9099af9
Skip certian platforms
mattleibow 05b5806
Load the SDK that matches the current build
mattleibow 9a5769a
oops
mattleibow 3251e8d
Use this instead
mattleibow 414f9eb
Include both versions
mattleibow ff60600
Support older SDKs
mattleibow ef6ee32
Each workload version has a single support
mattleibow 24bab94
Merge branch 'net7.0' into net7-include-net6-templates
mattleibow 10617b7
Seems this is OK
mattleibow 824e862
Get something that will work
mattleibow 32e3e98
this should be working now
mattleibow 52c7008
Merge remote-tracking branch 'origin/net7.0' into net7-include-net6-t…
mattleibow fec5c75
Use the next stable version
mattleibow 565393e
better formatting
mattleibow 642ef54
Merge branch 'net7.0' into net7-include-net6-templates
mattleibow a5b616c
Merge branch 'net7.0' into net7-include-net6-templates
mattleibow ab144cd
The last version that worked
mattleibow 8c67680
Merge branch 'net7.0' into net7-include-net6-templates
mattleibow 4cf8400
Due to a bug
mattleibow 58a6344
Merge branch 'net7.0' into net7-include-net6-templates
mattleibow 37b67ef
not much works
mattleibow 7801e7d
Merge remote-tracking branch 'origin/net7.0' into net7-include-net6-t…
mattleibow e313ece
Merge remote-tracking branch 'origin/net7.0' into net7-include-net6-t…
mattleibow 4dfe8bd
Merge remote-tracking branch 'origin/net7.0' into net7-include-net6-t…
mattleibow 8245fcb
Try .net6.0 again
mattleibow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
src/Workload/Microsoft.NET.Sdk.Maui/WorkloadManifest.in.targets
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
<Project> | ||
|
||
<ItemGroup Condition=" '$(UseMaui)' == 'true' or '$(UseMauiCore)' == 'true' "> | ||
<ProjectCapability Include="UseMauiCore" /> | ||
<ProjectCapability Condition=" '$(UseMaui)' == 'true' " Include="UseMaui" /> | ||
</ItemGroup> | ||
|
||
<Import | ||
Condition=" ('$(UseMaui)' == 'true' or '$(UseMauiCore)' == 'true' or '$(UseMauiEssentials)' == 'true' or '$(UseMauiAssets)' == 'true') and ($([MSBuild]::VersionEquals($(TargetFrameworkVersion), '@MAUI_DOTNET_VERSION@'))) " | ||
Project="Sdk.targets" Sdk="Microsoft.Maui.Sdk" | ||
/> | ||
<Import | ||
Condition=" ('$(UseMaui)' == 'true' or '$(UseMauiCore)' == 'true' or '$(UseMauiEssentials)' == 'true' or '$(UseMauiAssets)' == 'true') and ($([MSBuild]::VersionEquals($(TargetFrameworkVersion), '@MAUI_PREVIOUS_DOTNET_VERSION@'))) " | ||
Project="Sdk.targets" Sdk="Microsoft.Maui.Sdk-@MAUI_PREVIOUS_DOTNET_VERSION@" | ||
/> | ||
|
||
<Import | ||
Condition=" '$(UseMaui)' == 'true' or '$(UseMauiAssets)' == 'true' " | ||
Project="Sdk.targets" Sdk="Microsoft.Maui.Resizetizer.Sdk" | ||
/> | ||
|
||
<!-- | ||
Previous versions of the .NET MAUI SDK used **FromWorkload**, so replace with explicit versions. | ||
The BundledVersions.targets that is imported is from the previous SDK, so all the other values are correct. | ||
--> | ||
<ItemGroup Condition=" $([MSBuild]::VersionEquals($(TargetFrameworkVersion), '@MAUI_PREVIOUS_DOTNET_VERSION@')) "> | ||
<KnownFrameworkReference | ||
Update="Microsoft.Maui.Core" | ||
DefaultRuntimeFrameworkVersion="@MAUI_PREVIOUS_DOTNET_RELEASED_NUGET_VERSION@" | ||
LatestRuntimeFrameworkVersion="@MAUI_PREVIOUS_DOTNET_RELEASED_NUGET_VERSION@" | ||
TargetingPackVersion="@MAUI_PREVIOUS_DOTNET_RELEASED_NUGET_VERSION@" | ||
/> | ||
<KnownFrameworkReference | ||
Update="Microsoft.Maui.Controls" | ||
DefaultRuntimeFrameworkVersion="@MAUI_PREVIOUS_DOTNET_RELEASED_NUGET_VERSION@" | ||
LatestRuntimeFrameworkVersion="@MAUI_PREVIOUS_DOTNET_RELEASED_NUGET_VERSION@" | ||
TargetingPackVersion="@MAUI_PREVIOUS_DOTNET_RELEASED_NUGET_VERSION@" | ||
/> | ||
<KnownFrameworkReference | ||
Update="Microsoft.Maui.Essentials" | ||
DefaultRuntimeFrameworkVersion="@MAUI_PREVIOUS_DOTNET_RELEASED_NUGET_VERSION@" | ||
LatestRuntimeFrameworkVersion="@MAUI_PREVIOUS_DOTNET_RELEASED_NUGET_VERSION@" | ||
TargetingPackVersion="@MAUI_PREVIOUS_DOTNET_RELEASED_NUGET_VERSION@" | ||
/> | ||
</ItemGroup> | ||
|
||
</Project> |
14 changes: 0 additions & 14 deletions
14
src/Workload/Microsoft.NET.Sdk.Maui/WorkloadManifest.targets
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be replaced with the shipping version of MAUI SR2