Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Revert recent changes to fix Layout issues #8136

Merged
merged 3 commits into from
Jun 21, 2022
Merged

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Jun 17, 2022

Description of Change

This PR revert changes from e4aa6df to fix the current Layout issues having a big impact on Android. Ideally this PR should have an alternative implementation to fix the reverted changes issue #3643, but since this is affecting several Core properties, we will reopen the original issue and not wait any longer to fix the Layout issues.

fix-8071

Issues Fixed

Fixes #8044
Fixes #8129
Fixes #8084
Fixes #8071
Fixes #8405
Fixes #8445
Fixes #8574
Fixes #8615

@jsuarezruiz jsuarezruiz added t/bug Something isn't working area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter platform/android 🤖 fatal labels Jun 17, 2022
@jsuarezruiz jsuarezruiz added this to the 6.0-sr2 milestone Jun 17, 2022
@jsuarezruiz jsuarezruiz modified the milestones: 6.0-sr2, 6.0-sr3 Jun 17, 2022
@jsuarezruiz jsuarezruiz modified the milestones: 6.0-sr3, 6.0-sr2 Jun 20, 2022
@Redth Redth requested a review from rmarinho June 20, 2022 13:38
@ederbond
Copy link
Contributor

@jsuarezruiz when is this going to be released?
We need it ASAP. Break the release cadence rules of MAUI at least this time and release it sooner. This is a fatal error that's making MAUI completely useless for production Apps now.
@jamesmontemagno @hartez @StephaneDelcroix @davidortinau @maddymontaquila

@Symbai
Copy link
Contributor

Symbai commented Jun 20, 2022

Break the release cadence rules of MAUI at least this time and release it sooner

As soon as its merged you can use the nightly build: #7653

@PaulAndersonS
Copy link
Contributor

image

Can we expect an update for this fix on June 22, 2022

@shinnthant-lab
Copy link

When will this be available for Update?? ETA pls, thanks

@Symbai
Copy link
Contributor

Symbai commented Jun 24, 2022

When will this be available for Update?? ETA pls, thanks

#8136 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter fixed-in-6.0.408 Look for this fix in 6.0.408! platform/android 🤖 t/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants