Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CharacterSpacing property in TimePickerHandlers #555

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Implement CharacterSpacing property in TimePickerHandlers #555

merged 1 commit into from
Mar 22, 2021

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Mar 19, 2021 •
edited
Loading

Description of Change

Implement CharacterSpacing property in TimePickerHandlers.

Related issue #439

Platforms Affected

  • Core
  • iOS
  • Android

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

@hartez hartez merged commit 62373cf into main Mar 22, 2021
@hartez hartez deleted the timepicker-characterspacing branch March 22, 2021 22:18
shyunMin added a commit to shyunMin/maui that referenced this pull request Nov 18, 2022
@shyunMin
Add Shell.SearchHandler (dotnet#555)
df7f965 
* [Tizen] Add Shell.SearchHandler

* Update Flyout to apply ItemTemplate and MenuItemTemplate

* Update Tabbar to apply Shell.BackgroundColor

* Update based on review feedback

* Update Tab appearance

* Update Tabbar with review feedback

* Update based on review feedback

* Remove unnecessary code
shyunMin added a commit to shyunMin/maui that referenced this pull request Nov 18, 2022
@shyunMin
Add Shell.SearchHandler (dotnet#555)
c5ba9bd 
* [Tizen] Add Shell.SearchHandler

* Update Flyout to apply ItemTemplate and MenuItemTemplate

* Update Tabbar to apply Shell.BackgroundColor

* Update based on review feedback

* Update Tab appearance

* Update Tabbar with review feedback

* Update based on review feedback

* Remove unnecessary code
shyunMin added a commit to shyunMin/maui that referenced this pull request Nov 24, 2022
@shyunMin
Add Shell.SearchHandler (dotnet#555)
ab879b4 
* [Tizen] Add Shell.SearchHandler

* Update Flyout to apply ItemTemplate and MenuItemTemplate

* Update Tabbar to apply Shell.BackgroundColor

* Update based on review feedback

* Update Tab appearance

* Update Tabbar with review feedback

* Update based on review feedback

* Remove unnecessary code
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hartez hartez hartez approved these changes

Assignees
No one assigned
Labels
area-controls-picker Picker fixed-in-6.0.100-preview.3.2 platform/android 🤖 platform/iOS 🍎
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsuarezruiz @hartez @Eilon @samhouts