[Windows]Fixed Shell Navigating event issue when switching tabs #27197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @Vignesh-SF3580! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
karthikraja-arumugam
added
the
partner/syncfusion
|
/azp run |
This comment was marked as outdated.
This comment was marked as outdated.
jsuarezruiz
added
platform/windows 🪟
area-controls-shell
4 tasks
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
force-pushed
the
windowsFix-25599
branch
from
8a241b3 to
e7d0ff6
Compare
|
/azp run |
This comment was marked as off-topic.
This comment was marked as off-topic.
jsuarezruiz
previously requested changes
Jan 23, 2025
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
windowsFix-25599
branch
from
8b5e99b to
ea2e895
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
For future reference: you could have written a unit test instead that checked for the event 🙂 |
Foda
approved these changes
Jan 30, 2025
jfversluis
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Detail
The Navigating event was not triggered when switching tabs.
Root Cause
There was no code in place to trigger the Navigating event upon tab switches.
Description of Change
Added logic to trigger Navigating when switching to a different tab.
Tested the behavior in the following platforms
Issues Fixed
Fixes #25599
Screenshots
BeforeFix.mp4
AfterFix1.mp4